Re: max8997 cleanup bug?

[Lee Jones]

On Wed, 05 Feb 2025, Dr. David Alan Gilbert wrote:

> Hi Lee,
>   I noticed that:
>    drivers/mfd/max8997-irq.c    max8997_irq_exit
> isn't called anywhere and was about to send a deadcode patch,
> but I'm thinking it's actually a bug and it should be called.
> 
>   Looking at the max8998, it has basically the same function,
> and it calls it from an error path in it's max8998_i2c_probe.
> There's no equivalent call in max8997's probe.
> 
>   To me it looks like it probably goes after the 'err_i2c_haptic:'
> label, but I don't know the code and as far as I know I don't
> have one of the devices.
> 
>   Any thoughts?

I would convert to devm_request_threaded_irq() and remove it.

-- 
Lee Jones [李琼斯]