Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

[Varadarajan Narayanan]

On Wed, Feb 05, 2025 at 02:47:13PM +0100, Krzysztof Kozlowski wrote:
> On 05/02/2025 11:49, Varadarajan Narayanan wrote:
> > On Mon, Feb 03, 2025 at 05:30:32PM +0100, Krzysztof Kozlowski wrote:
> >> On 28/01/2025 07:27, Varadarajan Narayanan wrote:
> >>>
> >>> @@ -479,6 +519,230 @@ frame@b128000 {
> >>>  				status = "disabled";
> >>>  			};
> >>>  		};
> >>> +
> >>> +		pcie1: pcie@18000000 {
> >>> +			compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
> >>> +			reg = <0x00088000 0x3000>,
> >>
> >> So as Konrad pointed out now, this was never tested. It's not we who
> >> should run tests for you. It's you.
> >
> > This was tested and it did not flag an error since it is having the order
> > specified in the bindings. qcom,pcie.yaml has 4 reg specifications. Two of
>
>
> Hm, then please paste results of dtbs_check W=1 testing. Here.
>
> I am 100% sure you have there warning and I don't understand your
> reluctance to run the tests even after pointing it out by two people.

I ran the tests. Not sure which portions to paste. Have attached the full
output just in case you are interested in some other detail. Please take a
look.

Thanks
Varada

	$ grep ipq.*dtb dtbs-check.log
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp441.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp442.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp468.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdd-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdda-pll-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdda-phy-dpdm-supply' is a required property
	Check:  arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: usb@70f8800: interrupt-names: ['pwr_event', 'qusb2_phy'] is too short
	Check:  arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq5332-rdp442.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq5332-rdp468.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq5332-rdp441.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb
	arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: /soc@0/remoteproc@cd00000: failed to match any schema with compatible: ['qcom,ipq6018-wcss-pil']
	  DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb
	  DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdd-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdda-pll-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdda-phy-dpdm-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdd-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdda-pll-supply' is a required property
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdda-phy-dpdm-supply' is a required property
	  DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
	Check:  arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
	Check:  arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dtb
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
	/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
	Check:  arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb
	Check:  arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb

Attachment: dtbs-check.log.gz
Description: application/gzip