Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

From: Krzysztof Kozlowski
Date: Wed Feb 05 2025 - 10:54:38 EST


On 05/02/2025 16:35, Varadarajan Narayanan wrote:
> On Wed, Feb 05, 2025 at 02:47:13PM +0100, Krzysztof Kozlowski wrote:
>> On 05/02/2025 11:49, Varadarajan Narayanan wrote:
>>> On Mon, Feb 03, 2025 at 05:30:32PM +0100, Krzysztof Kozlowski wrote:
>>>> On 28/01/2025 07:27, Varadarajan Narayanan wrote:
>>>>>
>>>>> @@ -479,6 +519,230 @@ frame@b128000 {
>>>>> status = "disabled";
>>>>> };
>>>>> };
>>>>> +
>>>>> + pcie1: pcie@18000000 {
>>>>> + compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
>>>>> + reg = <0x00088000 0x3000>,
>>>>
>>>> So as Konrad pointed out now, this was never tested. It's not we who
>>>> should run tests for you. It's you.
>>>
>>> This was tested and it did not flag an error since it is having the order
>>> specified in the bindings. qcom,pcie.yaml has 4 reg specifications. Two of
>>
>>
>> Hm, then please paste results of dtbs_check W=1 testing. Here.
>>
>> I am 100% sure you have there warning and I don't understand your
>> reluctance to run the tests even after pointing it out by two people.
>
> I ran the tests. Not sure which portions to paste. Have attached the full
> output just in case you are interested in some other detail. Please take a
> look.
>
> Thanks
> Varada
>
> $ grep ipq.*dtb dtbs-check.log

Where is the command you have used?

Best regards,
Krzysztof