Re: [PATCH v2 3/3] pci/msi: remove pci_msi_ignore_mask
From: Bjorn Helgaas
Date: Thu Feb 06 2025 - 11:02:51 EST
On Thu, Feb 06, 2025 at 09:33:26AM +0100, Roger Pau Monné wrote:
> On Wed, Feb 05, 2025 at 09:17:31AM -0600, Bjorn Helgaas wrote:
> > Please run git log --oneline and match the subject line capitalization
> > style, i.e.,
> >
> > PCI/MSI: Remove ...
> >
> > But it doesn't look like this actually *removes* the functionality, it
> > just implements it differently so it can be applied more selectively.
> >
> > So maybe the subject should say something like "control use of MSI
> > masking per IRQ domain, not globally"
>
> What about:
>
> PCI/MSI: convert pci_msi_ignore_mask to per MSI domain flag
>
> Which is slightly shorter?
Much better. Also capitalize "Convert".