Re: [PATCH RFC 01/33] scsi, usb: Rename the RESERVE and RELEASE constants

[Christoph Hellwig]

On Thu, Feb 06, 2025 at 09:50:42AM -0800, Bart Van Assche wrote:
> The RESERVE(6) and RELEASE(6) commands are obsolete SCSI commands defined
> in the SCSI-2 standard. These commands have been replaced by PERSISTENT
> RESERVE IN and PERSISTENT RESERVE OUT. Rename RESERVE into RESERVE_6 and
> RELEASE into RELEASE_6 in preparation of introducing a new RELEASE macro in
> the new header file include/linux/thread_safety.h.

The rename itself looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

But RELEASE is not a good name for a global macro, I'll return to that
argument later.