Re: [PATCH RFC 29/33] hwmon: (it87) Check the it87_lock() return value

From: Christoph Hellwig
Date: Thu Feb 06 2025 - 22:46:02 EST


On Thu, Feb 06, 2025 at 02:51:59PM -0800, Guenter Roeck wrote:
>> - it87_lock(data);
>> + int err = it87_lock(data);
>
> I am not going to accept patches with inline variable declarations
> if the patch is fixing an earlier problem, sorry. This only results
> in unnecessary backport failures.

In fact the inline variable declarations should never be used in
"normal" code by Linux coding standards. The only reason the
warning is disabled is for some of the magic scoping macros.