[PATCH next] RDMA/mana_ib: Fix error code in probe()
From: Dan Carpenter
Date: Fri Feb 07 2025 - 04:16:39 EST
Return -ENOMEM if dma_pool_create() fails. Don't return success.
Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/infiniband/hw/mana/device.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index 0a7553f819ba..a17e7a6b0545 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -144,8 +144,10 @@ static int mana_ib_probe(struct auxiliary_device *adev,
dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context->dev,
MANA_AV_BUFFER_SIZE, MANA_AV_BUFFER_SIZE, 0);
- if (!dev->av_pool)
+ if (!dev->av_pool) {
+ ret = -ENOMEM;
goto destroy_rnic;
+ }
ret = ib_register_device(&dev->ib_dev, "mana_%d",
mdev->gdma_context->dev);
--
2.47.2