Re: [PATCH net-next v2 0/2] net: core: improvements to device lookup by hardware address.

[Kuniyuki Iwashima]

From: Breno Leitao <leitao@xxxxxxxxxx>
Date: Mon, 10 Feb 2025 03:56:12 -0800
> The first patch adds a new dev_getbyhwaddr() helper function for

nit: second

> finding devices by hardware address when the RTNL lock is held. This
> prevents PROVE_LOCKING warnings that occurred when RTNL was held but the

Same comment for patch 2, this itself doens't fix the warning.
Also, patch 2 & 3 should be net.git materials ?  Maybe squash
the two and add a Fixes tag then.


> RCU read lock wasn't. The common address comparison logic is extracted
> into dev_comp_addr() to avoid code duplication.
> 
> The second patch adds missing documentation for the return value of

nit: first


> dev_getbyhwaddr_rcu(), fixing a warning reported by NIPA. The kdoc
> comment now properly specifies that the function returns either a
> pointer to net_device or NULL when no matching device is found.