Re: [PATCH net-next v2 0/2] net: core: improvements to device lookup by hardware address.
From: Breno Leitao
Date: Tue Feb 11 2025 - 06:45:46 EST
On Tue, Feb 11, 2025 at 10:09:27AM +0900, Kuniyuki Iwashima wrote:
> From: Breno Leitao <leitao@xxxxxxxxxx>
> Date: Mon, 10 Feb 2025 03:56:12 -0800
> > The first patch adds a new dev_getbyhwaddr() helper function for
>
> nit: second
>
> > finding devices by hardware address when the RTNL lock is held. This
> > prevents PROVE_LOCKING warnings that occurred when RTNL was held but the
>
> Same comment for patch 2, this itself doens't fix the warning.
> Also, patch 2 & 3 should be net.git materials ? Maybe squash
> the two and add a Fixes tag then.
I am not sure this should be against net, since the main user of it will
be targeting net-next.
Also, I don't see it as a fix itself, but a new API that users can
leverage once it is landed, thus, focusing on net-next.
Thanks for the review
--breno