Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[Arnd Bergmann]

On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> asking the user about these drivers when configuring a kernel that
> cannot run on an affected CZ.NIC Turris system.
>
> Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for 
> Turris Omnia MCU")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v2:
>   - Drop PPC_P2020 from the dependency list.

Looks good to me, one minor issue:

> @@ -6,6 +6,7 @@
> 
>  menuconfig CZNIC_PLATFORMS
>  	bool "Platform support for CZ.NIC's Turris hardware"
> +	depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST

Technically the MACH_ARMADA_38X check is redundant here, as that
already requires ARCH_MVEBU.

     Arnd