Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[Geert Uytterhoeven]

Hi Arnd,

On Tue, 11 Feb 2025 at 12:04, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> > CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> > Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> > asking the user about these drivers when configuring a kernel that
> > cannot run on an affected CZ.NIC Turris system.
> >
> > Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for
> > Turris Omnia MCU")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> > v2:
> >   - Drop PPC_P2020 from the dependency list.
>
> Looks good to me, one minor issue:
>
> > @@ -6,6 +6,7 @@
> >
> >  menuconfig CZNIC_PLATFORMS
> >       bool "Platform support for CZ.NIC's Turris hardware"
> > +     depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST
>
> Technically the MACH_ARMADA_38X check is redundant here, as that
> already requires ARCH_MVEBU.

Thanks for your comment!
Somehow I thought the former covers arm32, and the latter arm64,
but ARCH_MVEBU indeed covers both.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds