Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu

From: Pratyush Brahma
Date: Wed Feb 12 2025 - 00:20:37 EST



On 2/12/2025 10:09 AM, Pratyush Brahma wrote:


On 2/11/2025 8:45 PM, Krzysztof Kozlowski wrote:
On 11/02/2025 05:45, Pratyush Brahma wrote:
Add the device node for gfx smmu that is required for gpu
specific address translations.

Signed-off-by: Pratyush Brahma<quic_pbrahma@xxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/qcs8300.dtsi | 39 +++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
As pointed out by Rob, this wasn't ever tested. One more example of work
where you have the binding in the same patch but refuse to use it.
No, I had tested these patches against the dt_bindings_check and didn't see these errors.
It seems I need to upgrade my dtschema as Rob pointed out, reorder the clocks and resend.
However, I guess I need to update the clock list in the bindings file as per the order suggested
by Konrad in version 3.
NAK

Best regards,
Krzysztof
--
Thanks and Regards
Pratyush Brahma

--
Thanks and Regards
Pratyush Brahma