Re: [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add device node for gfx_smmu
From: Krzysztof Kozlowski
Date: Wed Feb 12 2025 - 00:38:08 EST
On 12/02/2025 06:19, Pratyush Brahma wrote:
>
> On 2/12/2025 10:09 AM, Pratyush Brahma wrote:
>>
>>
>> On 2/11/2025 8:45 PM, Krzysztof Kozlowski wrote:
>>> On 11/02/2025 05:45, Pratyush Brahma wrote:
>>>> Add the device node for gfx smmu that is required for gpu
>>>> specific address translations.
>>>>
>>>> Signed-off-by: Pratyush Brahma<quic_pbrahma@xxxxxxxxxxx>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 39 +++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 39 insertions(+)
>>> As pointed out by Rob, this wasn't ever tested. One more example of work
>>> where you have the binding in the same patch but refuse to use it.
> No, I had tested these patches against the dt_bindings_check and didn't
> see these errors.
> It seems I need to upgrade my dtschema as Rob pointed out, reorder the
> clocks and resend.
The reported errors are not relevant at all to upgraded or not upgraded
dtschema. This just wasn't tested.
>
Best regards,
Krzysztof