Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

From: Geert Uytterhoeven
Date: Wed Feb 12 2025 - 07:42:41 EST


Hi Vlastimil,

On Tue, 11 Feb 2025 at 17:01, Vlastimil Babka <vbabka@xxxxxxx> wrote:
> On 2/3/25 12:13, Vlastimil Babka wrote:
> > The subsystem status is currently reported with --role(stats) by
> > adjusting the maintainer role for any status different from Maintained.
> > This has two downsides:
> >
> > - if a subsystem has only reviewers or mailing lists and no maintainers,
> > the status is not reported (i.e. typically, Orphan subsystems have no
> > maintainers)
> >
> > - the Supported status means that someone is paid for maintaining, but
> > it is reported as "supporter" for all the maintainers, which can be
> > incorrect. People have been also confused about what "supporter"
> > means.
> >
> > This patch introduces a new --substatus option and functionality aimed
> > to report the subsystem status separately, without adjusting the
> > reported maintainer role. After the e-mails are output, the status of
> > subsystems will follow, for example:
> >
> > ...
> > linux-kernel@xxxxxxxxxxxxxxx (open list:LIBRARY CODE)
> > LIBRARY CODE status: Supported
> >
> > In order to allow replacing the role rewriting seamlessly, the new
> > option works as follows:
> >
> > - it is automatically enabled when --email and --role are enabled
> > (the defaults include --email and --rolestats which implies --role)
>
> With the following fixup, the above changes to:
>
> - it is automatically enabled when --email and --role are enabled and the
> output is a terminal (the defaults include --email and --rolestats which
> implies --role)
>
> ----8<----
> From f5523a85c742065fcb88a8aa26831f9dba9faf15 Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@xxxxxxx>
> Date: Tue, 11 Feb 2025 16:16:11 +0100
> Subject: [PATCH] get_maintainer: add --substatus for reporting subsystem
> status - fix
>
> The automatically enabled --substatus can break existing scripts that do
> not disable --rolestats. Require that script output goes to a terminal
> to enable it automatically.
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>

Thanks, that fixes the issue for me.
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds