Re: [PATCH v2 1/2] get_maintainer: add --substatus for reporting subsystem status

[Uwe Kleine-König]

On Wed, Feb 12, 2025 at 01:42:15PM +0100, Geert Uytterhoeven wrote:
> Hi Vlastimil,
> 
> On Tue, 11 Feb 2025 at 17:01, Vlastimil Babka <vbabka@xxxxxxx> wrote:
> > On 2/3/25 12:13, Vlastimil Babka wrote:
> > > The subsystem status is currently reported with --role(stats) by
> > > adjusting the maintainer role for any status different from Maintained.
> > > This has two downsides:
> > >
> > > - if a subsystem has only reviewers or mailing lists and no maintainers,
> > >   the status is not reported (i.e. typically, Orphan subsystems have no
> > >   maintainers)
> > >
> > > - the Supported status means that someone is paid for maintaining, but
> > >   it is reported as "supporter" for all the maintainers, which can be
> > >   incorrect. People have been also confused about what "supporter"
> > >   means.
> > >
> > > This patch introduces a new --substatus option and functionality aimed
> > > to report the subsystem status separately, without adjusting the
> > > reported maintainer role. After the e-mails are output, the status of
> > > subsystems will follow, for example:
> > >
> > > ...
> > > linux-kernel@xxxxxxxxxxxxxxx (open list:LIBRARY CODE)
> > > LIBRARY CODE status: Supported
> > >
> > > In order to allow replacing the role rewriting seamlessly, the new
> > > option works as follows:
> > >
> > > - it is automatically enabled when --email and --role are enabled
> > >   (the defaults include --email and --rolestats which implies --role)
> >
> > With the following fixup, the above changes to:
> >
> > - it is automatically enabled when --email and --role are enabled and the
> >   output is a terminal (the defaults include --email and --rolestats which
> >   implies --role)
> >
> > ----8<----
> > From f5523a85c742065fcb88a8aa26831f9dba9faf15 Mon Sep 17 00:00:00 2001
> > From: Vlastimil Babka <vbabka@xxxxxxx>
> > Date: Tue, 11 Feb 2025 16:16:11 +0100
> > Subject: [PATCH] get_maintainer: add --substatus for reporting subsystem
> >  status - fix
> >
> > The automatically enabled --substatus can break existing scripts that do
> > not disable --rolestats. Require that script output goes to a terminal
> > to enable it automatically.
> >
> > Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> 
> Thanks, that fixes the issue for me.
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Ditto for me (it allows me to undo the workaround I already implemented
:-)

Tested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

To please the regzbot, you also might want to add:

Fixes: c1565b6f7b53 ("get_maintainer: add --substatus for reporting subsystem status")
Closes: https://lore.kernel.org/all/7aodxv46lj6rthjo4i5zhhx2lybrhb4uknpej2dyz3e7im5w3w@w23bz6fx3jnn/

Thanks
Uwe

Attachment: signature.asc
Description: PGP signature