Re: [PATCH v2 23/31] watchdog: Switch to use hrtimer_setup()

[Thomas Gleixner]

On Tue, Feb 11 2025 at 08:16, Guenter Roeck wrote:
> On Wed, Feb 05, 2025 at 11:39:07AM +0100, Nam Cao wrote:
>> hrtimer_setup() takes the callback function pointer as argument and
>> initializes the timer completely.
>> 
>> Replace hrtimer_init() and the open coded initialization of
>> hrtimer::function with the new setup mechanism.
>> 
>> Patch was created by using Coccinelle.
>> 
>> Signed-off-by: Nam Cao <namcao@xxxxxxxxxxxxx>
>> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
>> Cc: linux-watchdog@xxxxxxxxxxxxxxx
>> ---
>
> Change log missing.

I read the above as a change log, but _I_ might be missing something.

> I am also personally not a friend of changing
> multiple drivers in a single patch for changes like this. That makes
> it all but impossible to revert one of the driver changes if it was
> wrong without reverting everything.

Come on. This is a purely mechanical change which is fully equivalent,
so splitting it up further is just increasing patch count for no value.

Thanks,

        tglx