Re: [PATCH v17 0/3] rust: xarray: Add a minimal abstraction for XArray
From: Danilo Krummrich
Date: Tue Feb 18 2025 - 10:21:53 EST
On Tue, Feb 18, 2025 at 09:37:42AM -0500, Tamir Duberstein wrote:
> Changes in v17:
> - Drop patch "rust: remove redundant `as _` casts". (Danilo Krummrich)
Just to clarify, I did not suggest to drop the patch, but rather move it after
patch 1 ("rust: types: add `ForeignOwnable::PointedTo`").
Instead you proposed to make this a good first issue, which is fine too.
> - Drop trailers for shared commit from configfs series[0]. (Danilo
> Krummrich)
Clarifying further, I pointed out that it's worth to consider dropping them when
making subsequent changes that haven't been discussed on the list and are not
listed in the change log (e.g. because they seem minor).
This was an expression of opinion, not a request.
> - Avoid shadowing expressions with .cast() calls. (Danilo Krummrich)
I appreciate that, thanks!