Re: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key
From: Jiri Kosina
Date: Tue Feb 18 2025 - 14:57:34 EST
On Mon, 17 Feb 2025, Aditya Garg wrote:
> From: Aditya Garg <gargaditya08@xxxxxxxx>
>
> This commit simplifies the logic in appletb_kbd_inp_event used for
> switching between the media and function keys on pressing the fn key.
>
> We now also prevent touching the kbd->saved_mode variable in case the esc
> key only mode is chosen.
>
> The following small fixes have also been done in this patch:
>
> - A small comment style error has been fixed
> - Fixed spelling in MODULE_DESCRIPTION
> - I have added myself to MODULE_AUTHOR
>
> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
What a flood of patchseries :) I don't see any mentions on what are the
v1->v2->v3->v4 changes, could you please document that?
--
Jiri Kosina
SUSE Labs