Re: [PATCH v4 1/3] HID: hid-appletb-kbd: simplify logic used to switch between media and function keys on pressing fn key

[Aditya Garg]

Hi Jiri

> On 19 Feb 2025, at 1:27 AM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> 
> On Mon, 17 Feb 2025, Aditya Garg wrote:
> 
>> From: Aditya Garg <gargaditya08@xxxxxxxx>
>> 
>> This commit simplifies the logic in appletb_kbd_inp_event used for
>> switching between the media and function keys on pressing the fn key.
>> 
>> We now also prevent touching the kbd->saved_mode variable in case the esc
>> key only mode is chosen.
>> 
>> The following small fixes have also been done in this patch:
>> 
>> - A small comment style error has been fixed
>> - Fixed spelling in MODULE_DESCRIPTION
>> - I have added myself to MODULE_AUTHOR
>> 
>> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
> 
> What a flood of patchseries :) I don't see any mentions on what are the 
> v1->v2->v3->v4 changes, could you please document that?
> 

Extremely sorry for nor giving a changelog. I’ll make sure it’s done next time.

V2: Spellings in MODULE_DESCRIPTION were also fixed.
V3: The 3/3 patch was added since the bug was flagged by kernel test robot
V4: Extra tabs were removed from 3/3 as reported by Dan Carpenter.
> -- 
> Jiri Kosina
> SUSE Labs