Re: [RESEND PATCH] clk: socfpga: stratix10: Optimize local variables

From: Dinh Nguyen
Date: Wed Feb 19 2025 - 07:43:28 EST


On 2/19/25 04:44, Thorsten Blum wrote:
Since readl() returns a u32, the local variable reg can also have the
data type u32. Furthermore, mdiv and refdiv are derived from reg and can
also be a u32.

Since do_div() casts the divisor to u32 anyway, changing the data type
of refdiv to u32 removes the following Coccinelle/coccicheck warning
reported by do_div.cocci:

WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead

Compile-tested only.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
---
drivers/clk/socfpga/clk-pll-s10.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


Applied!

Thanks,
Dinh