Re: [PATCH 26/29] serial: 8250: use serial_in/out() helpers

From: Greg KH
Date: Thu Feb 20 2025 - 09:41:26 EST


On Thu, Feb 20, 2025 at 02:27:41PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 20, 2025 at 12:16:03PM +0100, Jiri Slaby (SUSE) wrote:
> > There are serial_in/out() helpers to be used instead of direct
> > p->serial_in/out(). Use them in various 8250 drivers.
>
> Is this just a mechanical (compile-only) conversion?
> IIRC 8250 DW code is twisted in some cases and it might
> be a possibility of dead loops, but I don't remember it
> by heart and haven't checked myself before writing this
> reply.
>
> TL;DR: this needs a thorough review.

Wonderful, are you going to do it? :)