Re: [PATCH v2 13/16] x86/mce: Unify AMD DFR handler with MCA Polling

[Yazen Ghannam]

On Thu, Feb 20, 2025 at 01:41:21AM +0000, Zhuo, Qiuxu wrote:
> > From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> > [...]
> > > Is the following check in machine_check_poll() needed before
> > > queuing/logging AMD's deferred error?
> > >
> > >        if (mca_cfg.dont_log_ce && !mce_usable_address(m))
> > >              //Just clear MCA_STATUS, but not queue/log errors.
> > >
> > 
> > Good question. Deferred errors are uncorrectable errors that don't need
> > immediate action. They are not correctable errors, so the 'dont_log_ce'
> > flag shouldn't apply.
> 
> Thanks for the explanation. 
> How about the 2nd check "mce_usable_address(m)"?
> 

It's not relevant. We want to always log deferred errors since they are
uncorrectable.

Thanks,
Yazen