Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport
From: Joe Damato
Date: Thu Feb 20 2025 - 13:11:39 EST
On Thu, Feb 20, 2025 at 12:31:21PM -0500, Adam Young wrote:
> On 2/6/25 19:30, Jeremy Kerr wrote:
>
> > Hi Adam,
> >
> > > Is that your only concern with this patch?
> > Yes, hence the ack. If there are other changes that you end up doing in
> > response to other reviews, then please address the spacing thing too,
> > but that certainly doesn't warrant a new revision on its own.
> >
> > > What else would need to happen in order for this to get ACKed at this
> > > point?
> > It already has an ack from me.
> >
> > As for actual merging: If the netdev maintainers have further reviews,
> > please address those. If not, I assume they would merge in this window.
>
> Should I resubmit this patch with a title that includes net-next in order
> for it to be picked up? I can see that there is stuff being pulled in and
> net-next for 6.14 is at RC2.
I am not a maintainer and I don't speak for them, but I've been
following this submission so my guess would be:
- Fix the spacing issue Jeremy pointed out
- Include Jeremy's ack in the updated patch
- Submit a v18 with net-next in the subject line, an indicate in
the cover letter the two changes you've made (spacing issue and
adding Jeremy's ack).