Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

[Macpaul Lin (林智斌)]

On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
> 
> 

[snip]

> > +             tcpc {
> > +                     compatible = "mediatek,mt6360-tcpc";
> > +                     interrupts-extended = <&pio 17
> > IRQ_TYPE_LEVEL_LOW>;
> > +                     interrupt-names = "PD_IRQB";
> > +
> > +                     connector {
> > +                             compatible = "usb-c-connector";
> > +                             label = "USB-C";
> > +                             data-role = "dual";
> > +                             op-sink-microwatt = <10000000>;
> > +                             power-role = "dual";
> > +                             try-power-role = "sink";
> 
> Would be appreciated if you could also complete the node by adding
> the pd-revision
> property, enabling full USBC Power Delivery for the MT6360 PMIC.
> 

Well, I have no idea about the pd-revision of MT6360.
I could found MT6360 supports PD 3.0 according to the datasheet,
however, I have no idea about the other fields like major and minor
values. Dear ChiYuan, could you help to provide the value of pd-
revision? The property has been defined in 
Documentation/devicetree/bindings/connector/usb-connector.yaml.


> Same for the alternate modes, adding the DP alt mode is a matter of
> seconds... and
> well, it does sound a bit weird to add alternate modes without a
> mux... so, in this
> case you can choose either to:
>   - Squash the two commits (tcpc, it5205) and do everything in one;
> or
>   - Add the alternate mode node to the connector in the commit
> introducing the mux.
> 
> Either of the two options is okay for me, so you choose.
> > 

Well, I could squash the two commits together and adding the DP alt
mode values in next version.

> > 
> >   &ssusb0 {
> > +     dr_mode = "otg";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&u3_p0_vbus>;
> > +     role-switch-default-mode = "peripheral";
> 
> There's no need for a default mode here, luckily the MediaTek MTU3
> controllers
> don't need that for real :-)

Okay, will drop it than.


Thanks.
Macpaul Lin

> Drop please.
> 
> Cheers,
> Angelo
> 
>