Re: [PATCH v4 1/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for TCPC port

[ChiYuan Huang]

On Fri, Feb 21, 2025 at 11:39:09AM +0000, Macpaul Lin (林智斌) wrote:
> On Thu, 2025-02-20 at 16:58 +0100, AngeloGioacchino Del Regno wrote:
> > 
> > 
> 
> [snip]
> 
> > > +             tcpc {
> > > +                     compatible = "mediatek,mt6360-tcpc";
> > > +                     interrupts-extended = <&pio 17
> > > IRQ_TYPE_LEVEL_LOW>;
> > > +                     interrupt-names = "PD_IRQB";
> > > +
> > > +                     connector {
> > > +                             compatible = "usb-c-connector";
> > > +                             label = "USB-C";
> > > +                             data-role = "dual";
> > > +                             op-sink-microwatt = <10000000>;
> > > +                             power-role = "dual";
> > > +                             try-power-role = "sink";
> > 
> > Would be appreciated if you could also complete the node by adding
> > the pd-revision
> > property, enabling full USBC Power Delivery for the MT6360 PMIC.
> > 
> 
> Well, I have no idea about the pd-revision of MT6360.
> I could found MT6360 supports PD 3.0 according to the datasheet,
> however, I have no idea about the other fields like major and minor
> values. Dear ChiYuan, could you help to provide the value of pd-
> revision? The property has been defined in 
> Documentation/devicetree/bindings/connector/usb-connector.yaml.
> 
Hi, Macpaul:

You can specify the version information to 3.1 version 1.6.
Just add the below property into the 'connector' node.

pd-revision = /bits/ 8 <0x03 0x01 0x01 0x06>;

Regards,
ChiYuan
......