Re: [Patch v2 10/24] perf/x86/intel: Process arch-PEBS records or record fragments

[Peter Zijlstra]

On Wed, Feb 26, 2025 at 01:20:37PM +0800, Mi, Dapeng wrote:

> > Also, should that workaround have been extended to also include
> > GLOBAL_STATUS_PERF_METRICS_OVF in that mask, or was that defect fixed
> > for every chip capable of metrics stuff?
> 
> hmm,  per my understanding, GLOBAL_STATUS_PERF_METRICS_OVF handling should
> only be skipped when fixed counter 3 or perf metrics are included in PEBS
> counter group. In this case, the slots and topdown metrics have been
> updated by PEBS handler. It should not be processed again.
> 
> @Kan Liang, is it correct?

Right, so the thing is, *any* PEBS event pending will clear METRICS_OVF
per:

                status &= x86_pmu.intel_ctrl | GLOBAL_STATUS_TRACE_TOPAPMI;