Re: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()

[Yazen Ghannam]

On Thu, Feb 27, 2025 at 04:25:00PM +0100, Borislav Petkov wrote:
> On Thu, Feb 13, 2025 at 04:45:55PM +0000, Yazen Ghannam wrote:
> > Also, move __mcheck_cpu_init_generic() after
> > __mcheck_cpu_init_prepare_banks() so that MCA is enabled after the first
> > MCA polling event.
> 
> The reason being?
> 
> Precaution?
> 
> It was this way since forever, why are you moving it now? Any particular
> reason?
> 

1) To read/clear old errors before turning on MCA. The updated
__mcheck_cpu_init_prepare_banks() function does this for the MCi_CTL
registers. This patch does this for the MCG_CTL register too.

2) To ensure that vendor-specific setup is finished beforehand also.

Thanks,
Yazen