Re: [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output

From: Willem de Bruijn
Date: Thu Feb 27 2025 - 11:38:52 EST


Kevin Krakauer wrote:
> The GRO selftests can flake and have some confusing behavior. These
> changes make the output and return value of GRO behave as expected, then
> deflake the tests.
>
> v2:
> - Split into multiple commits.
> - Reduced napi_defer_hard_irqs to 1.
> - Reduced gro_flush_timeout to 100us.
> - Fixed comment that wasn't updated.
>
> v1: https://lore.kernel.org/netdev/20250218164555.1955400-1-krakauer@xxxxxxxxxx/

For next time: add target: [PATCH net-next]


> Kevin Krakauer (3):
> selftests/net: have `gro.sh -t` return a correct exit code
> selftests/net: only print passing message in GRO tests when tests pass
> selftests/net: deflake GRO tests
>
> tools/testing/selftests/net/gro.c | 8 +++++---
> tools/testing/selftests/net/gro.sh | 7 ++++---
> tools/testing/selftests/net/setup_veth.sh | 3 ++-
> 3 files changed, 11 insertions(+), 7 deletions(-)
>
> --
> 2.48.1.658.g4767266eb4-goog
>