Re: [PATCH v6 17/19] tests/acpi: virt: update HEST and DSDT tables

[Igor Mammedov]

On Fri, 28 Feb 2025 10:44:22 +0100
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:

> Em Fri, 28 Feb 2025 17:33:18 +0800
> Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> escreveu:
> 
> > On Thu, 27 Feb 2025 17:00:55 +0100
> > Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:
> >   
> > > - The HEST table now accept two sources;
> > > - The DSDT tables now have a GED error device.
> > > 
> > > @@ -1,39 +1,39 @@
> > >  /*
> > >   * Intel ACPI Component Architecture
> > >   * AML/ASL+ Disassembler version 20240322 (64-bit version)
> > >   * Copyright (c) 2000 - 2023 Intel Corporation
> > >   *
> > > - * Disassembly of tests/data/acpi/aarch64/virt/HEST
> > > + * Disassembly of /tmp/aml-DMPE22    
> > This is an artifact of where you happened to get file
> > from so if we are being really fussy drop the change 
> > diff in the patch description for it.  I don't really care though.  
> > >   *    
> 
> True, but on the other hand, this is the only place at the diff
> saying what table the diff is against (HEST, in this case), as I had to
> remove the information before @@, as it was causing troubles when Igor
> were trying to apply the patch (plus on checkpatch).
> 
> That' why I opted to keep this hunk.

I'd drop this up to '* ACPI Data Table [HEST]' line.
But doesn't really matter, as long as reader can get what 's going on.
(there were precedents just putting snippets of diff)

Acked-by: Igor Mammedov <imammedo@xxxxxxxxxx>

> 
> Regards,
> Mauro
> 
> 
> Thanks,
> Mauro
>