Re: [PATCH 2/2] regulator: adp5055: Add driver for adp5055

[Mark Brown]

On Fri, Feb 28, 2025 at 04:01:37AM +0000, Torreno, Alexis Czezar wrote:

> > You've open coded the operations instead of using the framework helpers, you
> > shouldn't need to anything other than supply data here.

> I did code this similar to the helper functions like regulator_enable_regmap.

Yes, that's the problem - you shouldn't be copying them at all.

> if having both gpio and register enable isn't that common, I guess it's an option 
> to remove the gpios and stay purely software

It's extremely common to have the option of choosing between a register
and a GPIO, that should just work with the framework code - we should
use the GPIO over the register if it's available.

Attachment: signature.asc
Description: PGP signature