Re: [PATCH v3 2/9] dt-bindings: qcom: se-common: Add QUP Peripheral-specific properties for I2C, SPI, and SERIAL bus

[Krzysztof Kozlowski]

On Mon, Mar 03, 2025 at 06:13:42PM +0530, Viken Dadhaniya wrote:
> Introduce a new YAML schema for QUP-supported peripherals. Define common
> properties used across QUP-supported peripherals.
> 
> Add property `qcom,gsi-dma-allowed` to configure the Serial Engine (SE) for
> QCOM GPI DMA mode.
> 
> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
> ---
>  .../soc/qcom/qcom,se-common-props.yaml        | 26 +++++++++++++++++++
>  1 file changed, 26 insertions(+)

You miss here any user of this.

>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,se-common-props.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,se-common-props.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,se-common-props.yaml
> new file mode 100644
> index 000000000000..a111e51bb1c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,se-common-props.yaml
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,se-common-props.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QUP Peripheral-specific properties for I2C, SPI and SERIAL bus.

Drop full stop. Titles never have them.

> +
> +description:
> +  The Generic Interface (GENI) based Qualcomm Universal Peripheral (QUP) is
> +  a programmable module that supports a wide range of serial interfaces
> +  such as UART, SPI, I2C, I3C, etc. This defines the common properties used
> +  across QUP-supported peripherals.
> +
> +maintainers:
> +  - Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> +  - Viken Dadhaniya <quic_vdadhani@xxxxxxxxxxx>
> +
> +properties:
> +  qcom,gsi-dma-allowed:

Based on description: qcom,enable-gsi-dma
(or description is not accurate)

> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Configure the Serial Engine (SE) to transfer data in QCOM GPI DMA mode.
> +      By default, FIFO mode (PIO/CPU DMA) will be selected.

Best regards,
Krzysztof