Re: [PATCH v2 0/5] wfx: add support for WoWLAN on Silabs WF200

[Jérôme Pouiller]

On Monday 3 March 2025 09:20:11 CET Johannes Berg wrote:
> On Sun, 2025-03-02 at 15:47 +0100, Jérôme Pouiller wrote:
> > This is the initial support for Wake-on-WLAN of Silicon WF200 chipset. This
> > version focus on the power management control. For now, the filtering
> > capabilities of the chip are not exposed. So any multicast frame (= any ARP
> > request) will wake up the host.
> >
> > I have this series of patches in my git tree for a while. I hesitated to
> > send it because the code is based on a proof of concept and I don't have
> > access to the hardware anymore.
> >
> > Therefore, this feature is experimental. However, the only way to reach
> > this code is to run "iw phy phy0 wowlan enable" or explicitly enable it in
> > /sys. So, I believe it makes sense to merged it in the stable tree. Thus, I
> > hope some users will be able to report their success (or their failure).
> >
> > v2:
> >   - Fix compilation issue reported by "kernel test robot"[1]. Member
> >     'wowlan' only exist if CONFIG_PM.
> 
> You should probably check patchwork too - now that we're running some
> checks, a missing 'static' jumped out:
> 
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-wireless/list/?series=939353__;!!N30Cs7Jr!Ru1BMHVjq3TxTX0c6bA3EDM0EzKM7JcHyeEUJ3_-J4TFLsLpY-jDSudnehLp3DzQ4Nutky9oKreyyjRstvmwuPVT0tM$


Patchwork also reports two warnings that I am going to ignore:

  - "Target tree name not specified in the subject", I assume it
    is "wireless-next", but in the doubt I prefer to refrain.

  - Lines are larger then 80 columns. Checkpatch.pl now accepts up
    to 100 columns. I am not aware any local exception in net/, right?



-- 
Jérôme Pouiller