Re: [PATCH] drm/tiny: fix printk format string for 32-bit
From: Jani Nikula
Date: Tue Mar 04 2025 - 10:42:42 EST
On Tue, 04 Mar 2025, Aditya Garg <gargaditya08@xxxxxxxx> wrote:
> Hi
>
>> On 4 Mar 2025, at 7:57 PM, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>>
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> A size_t must be printed with the %z modifier instead of %l:
>>
>> In file included from include/linux/device.h:15,
>> from include/linux/usb.h:19,
>> from drivers/gpu/drm/tiny/appletbdrm.c:19:
>> drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_send_request':
>> include/drm/drm_print.h:589:54: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>> drivers/gpu/drm/tiny/appletbdrm.c:170:17: note: in expansion of macro 'drm_err'
>> 170 | drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>> | ^~~~~~~
>> drivers/gpu/drm/tiny/appletbdrm.c: In function 'appletbdrm_read_response':
>> include/drm/drm_print.h:589:54: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>> drivers/gpu/drm/tiny/appletbdrm.c:211:17: note: in expansion of macro 'drm_err'
>> 211 | drm_err(drm, "Actual size (%d) doesn't match expected size (%lu)\n",
>> | ^~~~~~~
>>
>> Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> —
>
> Its the duplicate of:
>
> https://lore.kernel.org/dri-devel/20250304-appletbdrm-fix-size_t-specifier-v1-1-94fe1d2c91f8@xxxxxxxxxx/
Pushed this one to drm-misc-next.
BR,
Jani.
>
> as well as
>
> https://lore.kernel.org/dri-devel/20250304135456.429407-1-jani.nikula@xxxxxxxxx/
>
>
--
Jani Nikula, Intel