Re: [PATCH 0/3] Adjust behavior for HPD sensor

[Jiri Kosina]

On Fri, 28 Feb 2025, Mario Limonciello wrote:

> From: Mario Limonciello <mario.limonciello@xxxxxxx>
> 
> Some platforms include a human presence detection (HPD) sensor. When
> enabled and a user is detected a wake event will be emitted from the
> sensor fusion hub that software can react to.
> 
> Example use cases are "wake from suspend on approach" or to "lock
> when leaving".
> 
> This is currently enabled by default on supported systems, but users
> can't control it. This essentially means that wake on approach is
> enabled which is a really surprising behavior to users that don't
> expect it.
> 
> Instead of defaulting to enabled add a sysfs knob that users can
> use to enable the feature if desirable and set it to disabled by
> default.
> 
> Cc: Pratap Nirujogi <pratap.nirujogi@xxxxxxx>
> Cc: Anson Tsao  <anson.tsao@xxxxxxx>
> 
> Mario Limonciello (3):
>   HID: amd_sfh: Allow configuring whether HPD is enabled or disabled
>   HID: amd_sfh: Default to HPD disabled
>   HID: amd_sfh: Don't show wrong status for amd_sfh_hpd_info()
> 
>  .../ABI/testing/sysfs-driver-amd-sfh          | 13 +++++
>  drivers/hid/amd-sfh-hid/amd_sfh_common.h      |  1 +
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        | 58 +++++++++++++++++++
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 50 +++++++++++++++-
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.h |  3 +
>  .../amd-sfh-hid/sfh1_1/amd_sfh_interface.c    |  2 +-
>  6 files changed, 124 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-amd-sfh

Now applied to hid.git#for-6.14/amd_sfh. Thanks,

-- 
Jiri Kosina
SUSE Labs