Re: [PATCH] drm/gma500: Remove unused mrst_helper_funcs

[Dr. David Alan Gilbert]

* Patrik Jakobsson (patrik.r.jakobsson@xxxxxxxxx) wrote:
> On Sat, Feb 1, 2025 at 2:14 AM <linux@xxxxxxxxxxx> wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > The mrst_helper_funcs const was added in 2013 by
> > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation")
> > and commented as 'Not used yet'.
> >
> > It's not been used since, so remove it.

Hi Patrik,

> You talk about mrst_helper_funcs but the patch removes
> mrst_clock_funcs. I assume this is not intentional.

Oops! Thanks for spotting that, I'll send a v2 fixing the commit
message; I think I was intending to write something like
'the helper functions it references are still used elsewhere.'

v2 coming up soon.

Dave

> -Patrik
> 
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> > index de8ccfe9890f..ea9b41af0867 100644
> > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> > @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = {
> >         .prepare = gma_crtc_prepare,
> >         .commit = gma_crtc_commit,
> >  };
> > -
> > -/* Not used yet */
> > -const struct gma_clock_funcs mrst_clock_funcs = {
> > -       .clock = mrst_lvds_clock,
> > -       .limit = mrst_limit,
> > -       .pll_is_valid = gma_pll_is_valid,
> > -};
> > --
> > 2.48.1
> >
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/