Re: [PATCH v6 4/5] x86/bugs: Declutter vulnerable CPU list

From: Dave Hansen
Date: Thu Mar 06 2025 - 10:19:03 EST


On 3/5/25 23:13, Pawan Gupta wrote:
...
> #define VULNWL_INTEL(vfm, whitelist) \
> - X86_MATCH_VFM(vfm, whitelist)
> + X86_MATCH_VFM(INTEL_##vfm, whitelist)

I think the new VFM code may have thrown you off here. Doing HASWELL_X
is not as nice as INTEL_HASWELL_X because, while you can grep for it, it
won't work when you're looking for full identifiers like with ctags or
cscope.

Also, this is just putting the "INTEL" in the macro instead of the VFM.
I'm not sure there's much value in doing:

VULNWL_INTEL(ALDERLAKE_L, ...)

over:

X86_MATCH_VFM(INTEL_ALDERLAKE_L, ...)

Before the 'vfm' stuff, we needed X86_VENDOR_INTEL in there somewhere.
But now that it's built in to INTEL_ALDERLAKE_L, we don't.