RE: [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs

[Parav Pandit]

> From: Tariq Toukan <tariqt@xxxxxxxxxx>
> Sent: Friday, March 7, 2025 2:55 AM
> 
> From: Jiri Pirko <jiri@xxxxxxxxxx>
> 
> Firmware version query is supported on the PFs. Due to this following kernel
> warning log is observed:
> 
> [  188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid
> 1453): fw query isn't supported by the FW
> 
> Fix it by restricting the query and devlink info to the PF.
> 
> Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
> Signed-off-by: Jiri Pirko <jiri@xxxxxxxxxx>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Reviewed-by: Parav Pandit <parav@xxxxxxxxxx>

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index 98d4306929f3..a2cf3e79693d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct
> devlink_info_req *req,
>  	u32 running_fw, stored_fw;
>  	int err;
> 
> +	if (!mlx5_core_is_pf(dev))
> +		return 0;
> +
>  	err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
>  	if (err)
>  		return err;
> --
> 2.45.0
>