Re: [PATCH v3 2/4] irqchip: Add support for Amlogic A4 and A5 SoCs

[Xianwei Zhao]

Hi Thomas,
   Thanks for your advice.

On 2025/3/7 16:01, Thomas Gleixner wrote:
> [ EXTERNAL EMAIL ]
>
> On Wed, Mar 05 2025 at 18:02, Xianwei Zhao via wrote:
> > @@ -358,16 +385,19 @@ static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl,
> >   {
> >        u32 val = 0;
> >        unsigned int idx;
> > +     const struct meson_gpio_irq_params *params;
> > +
> > +     params = ctl->params;
>
> Please fix up the variable declaration according to
>
>    https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations
>
> and initialize params right in the declaration.

Will fix.

> Thanks,
>
>          tglx