Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management

From: Russell King (Oracle)
Date: Mon Mar 10 2025 - 06:11:56 EST


On Mon, Mar 10, 2025 at 10:58:38AM +0100, Oleksij Rempel wrote:
> Hi Thangaraj,
>
> On Mon, Mar 10, 2025 at 09:29:45AM +0000, Thangaraj.S@xxxxxxxxxxxxx wrote:
> > > - mii_adv_to_linkmode_adv_t(fc, mii_adv);
> > > - linkmode_or(phydev->advertising, fc, phydev->advertising);
> > > + phy_suspend(phydev);
> > >
> >
> > Why phy_suspend called in the init? Is there any specific reason?
>
> In my tests with EVB-LAN7801-EDS, the attached PHY stayed UP in initial
> state.

Why is that an issue?

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!