Re: [PATCH net-next v2 1/7] net: usb: lan78xx: Convert to PHYlink for improved PHY and MAC management

[Oleksij Rempel]

On Mon, Mar 10, 2025 at 10:11:29AM +0000, Russell King (Oracle) wrote:
> On Mon, Mar 10, 2025 at 10:58:38AM +0100, Oleksij Rempel wrote:
> > Hi Thangaraj,
> > 
> > On Mon, Mar 10, 2025 at 09:29:45AM +0000, Thangaraj.S@xxxxxxxxxxxxx wrote:
> > > > -       mii_adv_to_linkmode_adv_t(fc, mii_adv);
> > > > -       linkmode_or(phydev->advertising, fc, phydev->advertising);
> > > > +       phy_suspend(phydev);
> > > > 
> > > 
> > > Why phy_suspend called in the init? Is there any specific reason?
> > 
> > In my tests with EVB-LAN7801-EDS, the attached PHY stayed UP in initial
> > state.
> 
> Why is that an issue?

The local interface was in the administrative DOWN state, but link was up:
- port LEDs are on
- link partner sees the link is UP.

It is not a big deal, but for me it looks inconsistent.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |