Re: [PATCH v2 07/11] perf python: Update ungrouped evsel leader in clone

[Arnaldo Carvalho de Melo]

On Fri, Feb 28, 2025 at 02:23:04PM -0800, Ian Rogers wrote:
> evsels are cloned in the python code as they form part of the Python
> object pyrf_evsel. The cloning doesn't update the evsel's leader, do
> this for the case of an evsel being ungrouped.

Reviewed-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

- Arnaldo
 
> Reviewed-by: Howard Chu <howardchu95@xxxxxxxxx>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  tools/perf/util/python.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index 4a3015e7dc83..e244cc74f16d 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
> @@ -1312,6 +1312,8 @@ static PyObject *pyrf_evsel__from_evsel(struct evsel *evsel)
>  	evsel__init(&pevsel->evsel, &evsel->core.attr, evsel->core.idx);
>  
>  	evsel__clone(&pevsel->evsel, evsel);
> +	if (evsel__is_group_leader(evsel))
> +		evsel__set_leader(&pevsel->evsel, &pevsel->evsel);
>  	return (PyObject *)pevsel;
>  }
>  
> -- 
> 2.48.1.711.g2feabab25a-goog