Re: [PATCH] x86/hweight: Fix and improve __arch_hweight{32,64}() assembly

[Uros Bizjak]

On Mon, Mar 10, 2025 at 9:45 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> On Mon, Mar 10, 2025 at 09:35:42PM +0100, Uros Bizjak wrote:
> > On Mon, Mar 10, 2025 at 9:12 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> > >
> > > On Mon, Mar 10, 2025 at 09:08:04PM +0100, Uros Bizjak wrote:
> > > > a) Use ASM_CALL_CONSTRAINT to prevent inline asm that includes call
> > > > instruction from being scheduled before the frame pointer gets set
> > > > up by the containing function, causing objtool to print a "call
> > > > without frame pointer save/setup" warning.
> > >
> > > The other two are ok but this is new. How do you trigger this? I've never seen
> > > it in my randconfig builds...
> >
> > It is not triggered now, but without this constraint, nothing prevents
> > the compiler from scheduling the insn in front of frame creation.
>
> Can you please stop with this silliness?
>
> When we start doing git archeology months, years from now, it should be
> perfectly clear why a commit was done. This one is not. So either the compiler
> is doing the bad scheduling or it isn't. Things can't just work by chance.
>
> Geez.

Ok, so let it be your way and let's just sweep the issue under the carpet.

BR,
Uros.