Re: [PATCH net v3] net: ethernet: ti: am65-cpsw: Fix NAPI registration sequence

[Sverdlin, Alexander]

Thanks Siddharth for reworking the patch!

On Tue, 2025-03-11 at 21:12 +0530, Siddharth Vadapalli wrote:
> From: Vignesh Raghavendra <vigneshr@xxxxxx>
> 
> Registering the interrupts for TX or RX DMA Channels prior to registering
> their respective NAPI callbacks can result in a NULL pointer dereference.
> This is seen in practice as a random occurrence since it depends on the
> randomness associated with the generation of traffic by Linux and the
> reception of traffic from the wire.
> 
> Fixes: 681eb2beb3ef ("net: ethernet: ti: am65-cpsw: ensure proper channel cleanup in error path")
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> Co-developed-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

LGTM,
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 32 +++++++++++++-----------
>  1 file changed, 18 insertions(+), 14 deletions(-)

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com