Re: [PATCH] Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE
From: Paul Menzel
Date: Wed Mar 12 2025 - 04:57:33 EST
[Cc: +Jonas Dreßler]
Dear Si-Jie,
Welcome to the mailing list, and thank you for your patch!
Am 12.03.25 um 09:38 schrieb Si-Jie Bai:
HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
page 371:
The above length is 66 characters (< 72), and fits in one line.
0x1A Unsupported Remote Feature
Maybe add:
The value was probably changed by mistake, when defining the macro.
Please add a Fixes: tag. It should be:
Fixes: 79c0868ad65a ("Bluetooth: hci_event: Use HCI error defines
instead of magic values")
Signed-off-by: Si-Jie Bai <sy2239101@xxxxxxxxxxx>
---
include/net/bluetooth/hci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 0d51970d8..3ec915738 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -683,7 +683,7 @@ enum {
#define HCI_ERROR_REMOTE_POWER_OFF 0x15
#define HCI_ERROR_LOCAL_HOST_TERM 0x16
#define HCI_ERROR_PAIRING_NOT_ALLOWED 0x18
-#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE 0x1e
+#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE 0x1a
#define HCI_ERROR_INVALID_LL_PARAMS 0x1e
#define HCI_ERROR_UNSPECIFIED 0x1f
#define HCI_ERROR_ADVERTISING_TIMEOUT 0x3c
With the above fixes, you can add:
Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Kind regards,
Paul