Re: [PATCH] Bluetooth: HCI: Fix value of HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE

[Luiz Augusto von Dentz]

Hi Si-Jie,

On Wed, Mar 12, 2025 at 4:39 AM Si-Jie Bai <sy2239101@xxxxxxxxxxx> wrote:
>
> HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE is actually 0x1a not 0x1e:
>
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 1, Part F
> page 371:
>
>   0x1A  Unsupported Remote Feature
>
> Signed-off-by: Si-Jie Bai <sy2239101@xxxxxxxxxxx>
> ---
>  include/net/bluetooth/hci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 0d51970d8..3ec915738 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -683,7 +683,7 @@ enum {
>  #define HCI_ERROR_REMOTE_POWER_OFF     0x15
>  #define HCI_ERROR_LOCAL_HOST_TERM      0x16
>  #define HCI_ERROR_PAIRING_NOT_ALLOWED  0x18
> -#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1e
> +#define HCI_ERROR_UNSUPPORTED_REMOTE_FEATURE   0x1a
>  #define HCI_ERROR_INVALID_LL_PARAMS    0x1e
>  #define HCI_ERROR_UNSPECIFIED          0x1f
>  #define HCI_ERROR_ADVERTISING_TIMEOUT  0x3c
> --
> 2.25.1

I tooked the following one over this since it better explains the
issue and had the Fixes tag:

https://patchwork.kernel.org/project/bluetooth/patch/20250312190943.152482-1-arkadiusz.bokowy@xxxxxxxxx/

-- 
Luiz Augusto von Dentz