Re: [PATCH] x86/asm: Use asm_inline() instead of asm() in amd_clear_divider()

From: Uros Bizjak
Date: Fri Mar 14 2025 - 07:03:49 EST


On Fri, Mar 14, 2025 at 11:15 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Borislav Petkov <bp@xxxxxxxxx> wrote:
>
> > Sorry but this doesn't justify this churn. There's nothing
> > quantifyingly palpable here to warrant this.
>
> I disagree, asm() is a known-bad inlining interface for fundamentally
> single-instruction inlines like this one, ...

Please note the new patch [1] that uses alternative_input(), where "no
code changes" actually supports the change. alternative_input() uses
asm_inline internally.

[1] https://lore.kernel.org/lkml/20250314081453.565859-1-ubizjak@xxxxxxxxx/

Uros.