Re: [PATCH v13 2/3] soc: sophgo: cv1800: rtcsys: New driver (handling RTC only)

[Alexander Sverdlin]

Hi Inochi!

On Fri, 2025-03-14 at 08:51 +0800, Inochi Amaoto wrote:
> On Sun, Mar 09, 2025 at 09:26:24PM +0100, Alexander Sverdlin wrote:
> > Add driver for Sophgo CV1800 series SoC RTC subsystem. The RTC module
> > comprises a 32kHz oscillator, Power-on-Reset (PoR) sub-module, HW state
> > machine to control chip power-on, power-off and reset. Furthermore, the
> > 8051 subsystem is located within RTCSYS including associated SRAM block.
> > 
> > This patch only populates RTC sub-device.
> > 
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>

...

> > +++ b/drivers/soc/sophgo/Kconfig
> > @@ -0,0 +1,24 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +#
> > +# Sophgo/Cvitek SoC drivers
> > +#
> > +
> > +if ARCH_SOPHGO || COMPILE_TEST
> 
> > +menu "Sophgo/Cvitek SoC drivers"
> 
> No Cvitek, only left Sophgo here.
> 
> > +
> > +config SOPHGO_CV1800_RTCSYS
> > +	tristate "Sophgo CV1800 RTC MFD"
> 
> > +	default y if COMPILE_TEST
> 
> I do not think it is necessary.

Maybe it should have been

tristate "Sophgo CV1800 RTC MFD" if COMPILE_TEST

like others do?

-- 
Alexander Sverdlin.