Re: [PATCH v13 2/3] soc: sophgo: cv1800: rtcsys: New driver (handling RTC only)

[Inochi Amaoto]

On Sat, Mar 15, 2025 at 12:43:19PM +0100, Alexander Sverdlin wrote:
> Hi Inochi!
> 
> On Fri, 2025-03-14 at 08:51 +0800, Inochi Amaoto wrote:
> > On Sun, Mar 09, 2025 at 09:26:24PM +0100, Alexander Sverdlin wrote:
> > > Add driver for Sophgo CV1800 series SoC RTC subsystem. The RTC module
> > > comprises a 32kHz oscillator, Power-on-Reset (PoR) sub-module, HW state
> > > machine to control chip power-on, power-off and reset. Furthermore, the
> > > 8051 subsystem is located within RTCSYS including associated SRAM block.
> > > 
> > > This patch only populates RTC sub-device.
> > > 
> > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> 
> ...
> 
> > > 
> > >   MAINTAINERS                        |  1 +
> > >   drivers/soc/Kconfig                |  1 +
> > >   drivers/soc/Makefile               |  1 +
> > >   drivers/soc/sophgo/Kconfig         | 24 ++++++++++++
> > >   drivers/soc/sophgo/Makefile        |  3 ++
> > >   drivers/soc/sophgo/cv1800-rtcsys.c | 63 ++++++++++++++++++++++++++++++
> > >   6 files changed, 93 insertions(+)
> > >   create mode 100644 drivers/soc/sophgo/Kconfig
> > >   create mode 100644 drivers/soc/sophgo/Makefile
> > >   create mode 100644 drivers/soc/sophgo/cv1800-rtcsys.c
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 3eee238c2ea2..ac15e448fffb 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -22354,6 +22354,7 @@ L:	sophgo@xxxxxxxxxxxxxxx
> > >   W:	https://github.com/sophgo/linux/wiki
> > >   T:	git https://github.com/sophgo/linux.git
> > >   S:	Maintained
> > 
> > > +F:	drivers/soc/sophgo/cv1800-rtcsys.c
> > 
> > Please change to the drivers/soc/sophgo/.
> > We should maintain all files under this.
> > 
> > >   N:	sophgo
> 
> I suppose my F: entry is actually superfluous because of the above
> N: entry and can be removed altogether?
> 

It is fine to tell others we do maintain these files, so it 
is fine for me to keep the entry point to "drivers/soc/sophgo/".

Regards,
Inochi