Re: [PATCH 2/8] arm64: dts: qcom: sc7180: Add specific APPS RSC compatible
From: Dmitry Baryshkov
Date: Tue Mar 18 2025 - 17:31:22 EST
On Tue, Mar 18, 2025 at 07:35:15PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> SC7180 comes in a couple firmware flavors, some of which don't support
> PSCI in OSI mode. That prevents the power domain exepcted by the RSC
> node from providing useful information on system power collapse.
Is this behaviour specific to SC7180 or only to ChromeBooks? For example
TCL Book 14 Go or ECS Liva QC710, would they also use this compat?
>
> Use the platform-specific compatible to allow not passing one.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 87c432c12a240f8035753ad10ce8662584a3f1f3..c79b256690fee8a20853e1662503e1f4250611af 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3720,7 +3720,7 @@ frame@17c2d000 {
> };
>
> apps_rsc: rsc@18200000 {
> - compatible = "qcom,rpmh-rsc";
> + compatible = "qcom,sc7180-rpmh-apps-rsc", "qcom,rpmh-rsc";
> reg = <0 0x18200000 0 0x10000>,
> <0 0x18210000 0 0x10000>,
> <0 0x18220000 0 0x10000>;
>
> --
> 2.48.1
>
--
With best wishes
Dmitry