Re: [PATCH 3/8] arm64: dts: qcom: sdm845: Add specific APPS RSC compatible
From: Dmitry Baryshkov
Date: Tue Mar 18 2025 - 17:32:16 EST
On Tue, Mar 18, 2025 at 07:35:16PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> SDM845 comes in a couple firmware flavors, some of which don't support
> PSCI in OSI mode. That prevents the power domain exepcted by the RSC
> node from providing useful information on system power collapse.
I think this quirk should be limited to those platforms only. Generic
SDM845 platforms should be able to provide this kind of info.
>
> Use the platform-specific compatible to allow not passing one.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 2968a5c541dc0a6c1c28e32160c4c40a8f332497..4466c08a8bb08075d71835e04733ff4dbf6f190b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -5264,8 +5264,8 @@ apss_shared: mailbox@17990000 {
> };
>
> apps_rsc: rsc@179c0000 {
> + compatible = "qcom,sdm845-rpmh-apps-rsc", "qcom,rpmh-rsc";
> label = "apps_rsc";
> - compatible = "qcom,rpmh-rsc";
> reg = <0 0x179c0000 0 0x10000>,
> <0 0x179d0000 0 0x10000>,
> <0 0x179e0000 0 0x10000>;
>
> --
> 2.48.1
>
--
With best wishes
Dmitry